-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DD4hep] Bump to new version #5604
Conversation
please test @andresailer
The tests are being triggered in jenkins. |
this last changes are fixing our ROOT master and ROOT 6-20 builds (I really hope so) ! |
-1 Tested at: cc103e6 CMSSW: CMSSW_11_1_X_2020-02-25-2300 I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: >> Entering Package PhysicsTools/TensorFlow Entering library rule at PhysicsTools/TensorFlow >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-25-2300/src/PhysicsTools/TensorFlow/src/TBBSession.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-25-2300/src/PhysicsTools/TensorFlow/src/TensorFlow.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-25-2300/src/PhysicsTools/TensorFlow/src/NTSession.cc /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-25-2300/src/PhysicsTools/TensorFlow/src/TBBSession.cc:51:10: fatal error: tensorflow/core/framework/graph.pb_text.h: No such file or directory #include "tensorflow/core/framework/graph.pb_text.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-25-2300/src/PhysicsTools/TensorFlow/src/NTSession.cc:49:10: fatal error: tensorflow/core/framework/graph.pb_text.h: No such file or directory #include "tensorflow/core/framework/graph.pb_text.h" |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
please test for CMSSW_11_1_X_2020-02-26-1100 |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: cc103e6 CMSSW: CMSSW_11_1_X_2020-02-26-1100 I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-26-1100/src/DetectorDescription/DDCMS/src/Filter.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-26-1100/src/DetectorDescription/DDCMS/src/DDFilteredView.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-26-1100/src/DetectorDescription/DDCMS/src/DDSpecparRegistry.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-26-1100/src/DetectorDescription/DDCMS/src/DDShapes.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-26-1100/src/DetectorDescription/DDCMS/src/DDAlgoArguments.cc /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-26-1100/src/DetectorDescription/DDCMS/src/DDAlgoArguments.cc:4:10: fatal error: DD4hep/BasicGrammar.h: No such file or directory #include "DD4hep/BasicGrammar.h" ^~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-26-1100/src/DetectorDescription/DDCMS/src/DDAlgoArguments.cc:4:10: fatal error: DD4hep/BasicGrammar.h: No such file or directory #include "DD4hep/BasicGrammar.h" |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
@andresailer I'd assume |
Yup it's called Grammar.h now. I'll fix i in the morning |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@ianna the cmssw one :) |
+1 |
please test
@andresailer